Script error in setOffsetOption() if !offsetParent #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offsetParent.getScroll() had thrown an error for !offsetParent. Because there is already an if condition with return, its moved after that condition.
|
Oh i see its a duplicate of #1122 but it isn't related to IE only. It happens at least when element is "position: fixed". |
|
👍 |
| offsetParent = element.measure(function(){ | ||
| return document.id(this.getOffsetParent()); | ||
| }), | ||
| parentScroll = offsetParent.getScroll(); | ||
| }); |
There was a problem hiding this comment.
can we use spaces here for indentation so it lines up with the line above? /nitpick
But otherwise I like the solution.
There was a problem hiding this comment.
With tabsize = 4 it looks right, I don't know how to fix this.
There was a problem hiding this comment.
Don't use tabs here. Use tabs up to the var indentation and then use spaces from there in. Not a huge deal. If you can't figure it out or don't have time, it's ok.
|
🚀 |
|
I just shipped it. 08f564d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetParent.getScroll()had thrown an error if!offsetParent. Because there is already an if condition with return, its moved after that condition.